ETT-1246 Requesting an OCN with spaces in it from the API returns a 403 #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the `.htaccess` rewrite rules for the Bib API so that spaces are escaped and passed through to `volumes.php` - This should reduce or eliminate `AH10411: Rewritten query string contains control characters or spaces` from the logs - Add a bail-out condition in `volumes.php`: - If a query term has been reduced to just whitespace, don't send to Solr - Add a filter on all query terms: - Remove all spaces after any other normalization has taken place - The existing lucene_escape should take care of anything else that might throw Solr for a loop - Behavior around when to return a 400 is unchanged. It only gets sent when all of the query terms or fields are bogus.
…ginx behavior is what we expect now from apache.
aelkiss
approved these changes
Jan 27, 2026
Member
aelkiss
left a comment
aelkiss
left a comment
There was a problem hiding this comment.
This seems OK to me. I wouldn't expect that removing spaces is necessarily going to get results where there weren't any, but I don't think it hurts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.htaccessrewrite rules for the Bib API so that spaces are escaped and passed through tovolumes.phpAH10411: Rewritten query string contains control characters or spacesfrom the logsvolumes.php:{"message":"query 'something:70628581' is invalid"}